-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1783] Upgrade springboot version #3834
base: main
Are you sure you want to change the base?
Conversation
- Add missing `quarkus-openapi-generator-oidc` dependency - Fix named Rest Client in integration tests
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3834 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3834/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.events.mongodb.QuarkusMongoDBEventPublisherTest.userTasksEventsCollectionjava.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0 at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:122) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) at io.quarkus.builder.BuildContext.run(BuildContext.java:256) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521) at java.base/java.lang.Thread.run(Thread.java:840) at org.jboss.threads.JBossThread.run(JBossThread.java:483) Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/mongo:7.0 at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330) at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.lambda$startMongo$0(DevServicesMongoProcessor.java:191) at java.base/java.util.Optional.orElseGet(Optional.java:364) at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:208) at io.quarkus.mongodb.deployment.DevServicesMongoProcessor.startMongo(DevServicesMongoProcessor.java:112) ... 9 more Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344) ... 14 more Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 15 more Caused by: java.lang.IllegalStateException: Wait strategy failed. Container exited with code 132 at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:533) ... 17 more Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(?i).*waiting for connections.*' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:909) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500) ... 17 more PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testPersistence1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testMultipleEmbeddedInstance1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testAdHocProcess1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testEmbeddedProcess1 expectation failed.Expected status code <201> but was <500>. org.kie.kogito.it.InfinispanOptimisticLockingIT.testStartApprovalAuthorized1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testAsyncWIH1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testParallelPersistence1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testPersistence1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testMultipleEmbeddedInstance1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testAdHocProcess1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testEmbeddedProcess1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testAsyncWIH1 expectation failed.Expected status code <201> but was <500>. PR check / Build projects / org.kie.kogito.it.InfinispanOptimisticLockingIT.testParallelPersistence1 expectation failed.Expected status code <201> but was <500>. |
…1783 # Conflicts: # addons/common/flyway/pom.xml # kogito-build/kogito-dependencies-bom/pom.xml # quarkus/addons/process-management/integration-tests/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If green, fine to merge it.
<version.org.infinispan>15.0.11.Final</version.org.infinispan> | ||
<version.org.infinispan.protostream>5.0.8.Final</version.org.infinispan.protostream> | ||
<!-- <version.org.infinispan>15.0.11.Final</version.org.infinispan>--> | ||
<!-- <version.org.infinispan.protostream>5.0.8.Final</version.org.infinispan.protostream>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gitgabrio Please remove those comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left them intentionally
I'll remove if the build is green
@@ -68,7 +68,7 @@ | |||
<version.com.sun.activation>2.0.1</version.com.sun.activation> | |||
<version.javax.inject>2.0.1</version.javax.inject> | |||
<version.org.eclipse.microprofile.openapi>3.1.1</version.org.eclipse.microprofile.openapi> | |||
<version.ch.qos.logback>1.4.14</version.ch.qos.logback> | |||
<version.ch.qos.logback>1.5.16</version.ch.qos.logback> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how this aligns with @LightGuard PRs for CVEs? apache/incubator-kie-drools#6236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrote comment there. IIUC, that PR changes only the kie-archatype poms
Looks like I’ll need to submit a new PR for tools, so everything is using
the same version.
Sent from Gmail Mobile
…On Wed, Jan 29, 2025 at 06:12 Gabriele Cardosi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In kogito-build/kogito-dependencies-bom/pom.xml
<#3834 (comment)>
:
> @@ -68,7 +68,7 @@
<version.com.sun.activation>2.0.1</version.com.sun.activation>
<version.javax.inject>2.0.1</version.javax.inject>
<version.org.eclipse.microprofile.openapi>3.1.1</version.org.eclipse.microprofile.openapi>
- <version.ch.qos.logback>1.4.14</version.ch.qos.logback>
+ <version.ch.qos.logback>1.5.16</version.ch.qos.logback>
Wrote comment
<apache/incubator-kie-drools#6236 (comment)>
there. IIUC, that PR changes only the kie-archatype poms
—
Reply to this email directly, view it on GitHub
<#3834 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHKE7SC6U5KDTDJXLGGBL2NDHSZAVCNFSM6AAAAABV5TMHKOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBRGAYDCMZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3834 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3834/3/display/redirect Test results:
Those are the test failures: org.kie.kogito.codegen.tests.PublishEventIT.testBasicUserTaskProcessAbortexpected: "UserTasksProcess" but was: "defaultPackage.TimerProcess" |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3834 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3834/4/display/redirect Test results:
Those are the test failures: org.kie.kogito.codegen.tests.PublishEventIT.testCompensationProcessExpected size: 9 but was: 11 in: [ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=30470760-23cc-49b6-a884-60cb41b93a56, connectionNodeInstanceId=SequenceFlow_1, nodeDefinitionId=_E76AD186-6FA6-4378-B45B-C8F73E2C497C, nodeName=timer fired, nodeType=ActionNode, nodeInstanceId=4190611f-981e-49b1-ad9d-3d027916090c, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=defaultPackage.TimerProcess, processVersion=1.0, processInstanceId=30470760-23cc-49b6-a884-60cb41b93a56, connectionNodeInstanceId=SequenceFlow_2, nodeDefinitionId=_F9AC8B12-8E75-49B5-B799-292F66270627, nodeName=start, nodeType=StartNode, nodeInstanceId=c27b156b-bc4a-4a6a-8b1b-f8476d3683ab, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=null, nodeDefinitionId=_B580FC2E-3924-472A-BCFB-A2ACBADA2B94, nodeName=Compensation 2, nodeType=ActionNode, nodeInstanceId=ab0cfea5-d0a0-4cd6-a0c3-602e003c112a, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=, nodeDefinitionId=_3F8F7865-7B32-4E44-B323-44CCBFC96C8F, nodeName=BoundaryEvent, nodeType=BoundaryEventNode, nodeInstanceId=e116d4e8-02fa-4e91-8820-498bb8396c12, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=null, nodeDefinitionId=_D91EB7E7-A287-4958-BF8E-27E364349BE9, nodeName=Compensation, nodeType=ActionNode, nodeInstanceId=fd115684-574e-4f1a-8917-0bae6d46fffd, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=, nodeDefinitionId=_C9728638-4D98-4C28-972D-C8C5A7CA0290, nodeName=BoundaryEvent, nodeType=BoundaryEventNode, nodeInstanceId=ae8030a0-0f3a-402e-87ae-4b3c541c1aaa, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=null, nodeDefinitionId=_E38F40D5-3A9A-4332-A4DC-CE0A2D37E179, nodeName=End, nodeType=EndNode, nodeInstanceId=c6a09c8e-05cc-48cd-8579-7aae3a235277, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=_457153B3-F67D-4D9F-ABF8-FFD10B6D934C, nodeDefinitionId=_CC9F5867-27CF-42CF-8838-648F44FD4CF1, nodeName=Compensate all tasks, nodeType=ActionNode, nodeInstanceId=6cd0e8d7-3d84-471d-b190-71b9f9b6a63b, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=_ACA65ACF-CBDA-4452-8C1A-609D54F1B749, nodeDefinitionId=_AA20EA8B-91E3-4171-8345-BFFBB103CD7F, nodeName=ScriptTask2, nodeType=ActionNode, nodeInstanceId=45f1460b-15f1-47c8-ae30-8a0d1b67e01e, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=_FF746A9A-D85F-4A83-918B-64808ACDE8E6, nodeDefinitionId=_8B1500BC-7458-4BFA-AB61-CC3AF6F375F9, nodeName=ScriptTask, nodeType=ActionNode, nodeInstanceId=083b0f56-2efd-4b81-8f7e-25e304b9adf1, data={}], ProcessInstanceNodeEventBody [eventDate=Thu Jan 30 05:57:04 EST 2025, eventUser=null, eventType=2, processId=compensateAll, processVersion=1.0, processInstanceId=a7524688-10d5-4a15-b7b3-79c8272dd773, connectionNodeInstanceId=_66C7CEB0-2A49-4328-9E9D-0AD75C898486, nodeDefinitionId=_8AD8A66C-6327-4F26-BB2E-314283BED823, nodeName=Start, nodeType=StartNode, nodeInstanceId=c35ddcb4-719e-4fdb-99c6-da8abc41c928, data={}]] |
Fixes apache/incubator-kie-issues#1783
Depends on:
apache/incubator-kie-kogito-examples#2061
apache/incubator-kie-kogito-apps#2182
This PR is built on top of #3750 (kudos @baldimir 🙏 )
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.